gtk4.git
6 years agoMerge branch 'wip/baedert/for-master' into 'master'
Timm Bäder [Tue, 25 Feb 2020 13:35:34 +0000 (13:35 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'

wip/baedert/for-master

See merge request GNOME/gtk!1466

6 years agostatusbar: Remove _get_message_area() from public API
Timm Bäder [Sun, 23 Feb 2020 15:53:53 +0000 (16:53 +0100)]
statusbar: Remove _get_message_area() from public API

The message should be manipulated via push() and pop().

6 years agoscrolledwindow: Remove an unnecessary cast
Timm Bäder [Sun, 23 Feb 2020 15:08:23 +0000 (16:08 +0100)]
scrolledwindow: Remove an unnecessary cast

6 years agoscrolledwindow: Remove useless local variables
Timm Bäder [Sun, 23 Feb 2020 14:57:10 +0000 (15:57 +0100)]
scrolledwindow: Remove useless local variables

6 years agowidget: Remove gtk_widget_input_shape_combine_region()
Timm Bäder [Sat, 22 Feb 2020 15:13:34 +0000 (16:13 +0100)]
widget: Remove gtk_widget_input_shape_combine_region()

Widget's don't have surfaces anymore these days.

6 years agoinspect-button: Use new gtk_window_set_extra_input_region
Timm Bäder [Sat, 22 Feb 2020 15:07:12 +0000 (16:07 +0100)]
inspect-button: Use new gtk_window_set_extra_input_region

6 years agowindow: Carry an extra input region
Timm Bäder [Sat, 22 Feb 2020 15:05:35 +0000 (16:05 +0100)]
window: Carry an extra input region

This will be used in the inspector to make it possible to click through
the inspector window.

6 years agopopover: Stop using gtk_widget_input_shape_combine_region()
Timm Bäder [Sat, 22 Feb 2020 14:28:44 +0000 (15:28 +0100)]
popover: Stop using gtk_widget_input_shape_combine_region()

We control the surface anyway, we can as well set the input shape on it
directly.

6 years agowidget: Remove set_csd_input_shape
Timm Bäder [Sat, 22 Feb 2020 14:25:49 +0000 (15:25 +0100)]
widget: Remove set_csd_input_shape

Replace the only caller (unsurprisingly from gtkwindow.c) with a direct
call to gdk_surface_input_shape_combine_region.

6 years agowidget: Remove surface member
Timm Bäder [Sat, 22 Feb 2020 13:55:52 +0000 (14:55 +0100)]
widget: Remove surface member

Only GtkNatives are supposed to have a surface, so use the widget's
native.

6 years agorange: Remove an outdated comment
Timm Bäder [Sat, 22 Feb 2020 13:12:16 +0000 (14:12 +0100)]
range: Remove an outdated comment

What even is a CList.

6 years agorange: Inline function into only caller
Timm Bäder [Sat, 22 Feb 2020 13:11:05 +0000 (14:11 +0100)]
range: Inline function into only caller

6 years agorange: Clean up compute_slider_position()
Timm Bäder [Sat, 22 Feb 2020 13:04:06 +0000 (14:04 +0100)]
range: Clean up compute_slider_position()

6 years agomenusectionbox: Avoid a gtk_widget_destroy() call
Timm Bäder [Sat, 22 Feb 2020 08:07:48 +0000 (09:07 +0100)]
menusectionbox: Avoid a gtk_widget_destroy() call

6 years agopathbar: Inherit from GtkWidget
Timm Bäder [Fri, 21 Feb 2020 14:24:19 +0000 (15:24 +0100)]
pathbar: Inherit from GtkWidget

6 years agocolorchooser: Fix typo in checkerboard color
Timm Bäder [Fri, 21 Feb 2020 12:58:49 +0000 (13:58 +0100)]
colorchooser: Fix typo in checkerboard color

6 years agoinspector: Remove double borders in recorder
Timm Bäder [Fri, 21 Feb 2020 12:38:38 +0000 (13:38 +0100)]
inspector: Remove double borders in recorder

6 years agoheaderbar: Replace gtk_widget_destroy() call
Timm Bäder [Fri, 21 Feb 2020 12:04:44 +0000 (13:04 +0100)]
headerbar: Replace gtk_widget_destroy() call

6 years agoheaderbar: Remove size request on icon button
Timm Bäder [Fri, 21 Feb 2020 11:57:16 +0000 (12:57 +0100)]
headerbar: Remove size request on icon button

Doesn't make sense that we force this one button to be this big.

6 years agoshortcutlabel: Remove unnecessary includes
Timm Bäder [Fri, 21 Feb 2020 08:37:00 +0000 (09:37 +0100)]
shortcutlabel: Remove unnecessary includes

6 years agostackswitcher: Avoid calling gtk_widget_destroy()
Timm Bäder [Fri, 21 Feb 2020 08:08:05 +0000 (09:08 +0100)]
stackswitcher: Avoid calling gtk_widget_destroy()

6 years agomodelbutton: Fix wrong function name in doc comment
Timm Bäder [Fri, 21 Feb 2020 08:04:27 +0000 (09:04 +0100)]
modelbutton: Fix wrong function name in doc comment

6 years agoplacessidebar: Convert popover menu to proper GtkPopoverMenu
Timm Bäder [Fri, 21 Feb 2020 08:03:32 +0000 (09:03 +0100)]
placessidebar: Convert popover menu to proper GtkPopoverMenu

6 years agoplacessidebar: Avoid calling gtk_widget_destroy()
Timm Bäder [Thu, 20 Feb 2020 18:56:56 +0000 (19:56 +0100)]
placessidebar: Avoid calling gtk_widget_destroy()

6 years agopathbar: Avoid calling gtk_widget_destroy()
Timm Bäder [Thu, 20 Feb 2020 18:36:13 +0000 (19:36 +0100)]
pathbar: Avoid calling gtk_widget_destroy()

6 years agoheaderbar: Avoid calling gtk_widget_destroy()
Timm Bäder [Thu, 20 Feb 2020 18:29:25 +0000 (19:29 +0100)]
headerbar: Avoid calling gtk_widget_destroy()

6 years agopopovermenubar: Avoid calling gtk_widget_destroy()
Timm Bäder [Thu, 20 Feb 2020 18:26:44 +0000 (19:26 +0100)]
popovermenubar: Avoid calling gtk_widget_destroy()

6 years agoemojichooser: Avoid using gtk_widget_destroy()
Timm Bäder [Thu, 20 Feb 2020 18:21:59 +0000 (19:21 +0100)]
emojichooser: Avoid using gtk_widget_destroy()

6 years agopopovermenu: Avoid a gtk_widget_destroy() call
Timm Bäder [Thu, 20 Feb 2020 17:05:00 +0000 (18:05 +0100)]
popovermenu: Avoid a gtk_widget_destroy() call

6 years agocolorchooserwidget: Get rid of a gtk_widget_destroy() call
Timm Bäder [Thu, 20 Feb 2020 16:54:56 +0000 (17:54 +0100)]
colorchooserwidget: Get rid of a gtk_widget_destroy() call

6 years agotestsuite: Remove outdated exclusions
Matthias Clasen [Tue, 25 Feb 2020 04:07:49 +0000 (23:07 -0500)]
testsuite: Remove outdated exclusions

There were mentions of GtkCList and GtkColorSelection
in these test. The memories!

6 years agoMerge branch 'spinning-spinner' into 'master'
Matthias Clasen [Tue, 25 Feb 2020 04:04:46 +0000 (04:04 +0000)]
Merge branch 'spinning-spinner' into 'master'

Rename GtkSpinner::active to ::spinning

See merge request GNOME/gtk!1475

6 years agoRename GtkSpinner::active to ::spinning
Matthias Clasen [Tue, 25 Feb 2020 02:04:49 +0000 (21:04 -0500)]
Rename GtkSpinner::active to ::spinning

And add a setter and getter. The old name was
confusing with the widget state of the same
name. 'Active' is just too overloaded.

6 years agoMerge branch 'kill-rtl-media-icons' into 'master'
Matthias Clasen [Tue, 25 Feb 2020 02:09:52 +0000 (02:09 +0000)]
Merge branch 'kill-rtl-media-icons' into 'master'

Drop rtl variants of media-playback-start

See merge request GNOME/gtk!1474

6 years agoMerge branch 'kill-popover-relative-to' into 'master'
Matthias Clasen [Tue, 25 Feb 2020 02:00:50 +0000 (02:00 +0000)]
Merge branch 'kill-popover-relative-to' into 'master'

Drop GtkPopover::relative-to

See merge request GNOME/gtk!1471

6 years agoDrop rtl variants of media-playback-start
Matthias Clasen [Tue, 25 Feb 2020 01:49:10 +0000 (20:49 -0500)]
Drop rtl variants of media-playback-start

According to #2469, they are unwanted.

6 years agopopover: Drop ::relative-to
Matthias Clasen [Mon, 24 Feb 2020 12:21:46 +0000 (07:21 -0500)]
popover: Drop ::relative-to

It is enough to just set the parent (and make the parent
call gtk_native_check_resize in size_allocate).

This commit removes the relative_to argument to the
constructors of GtkPopover and GtkPopoverMenu, and
updates all callers.

6 years agoMerge branch 'surface-get-mapped' into 'master'
Matthias Clasen [Tue, 25 Feb 2020 00:26:42 +0000 (00:26 +0000)]
Merge branch 'surface-get-mapped' into 'master'

Add gdk_surface_get_mapped

See merge request GNOME/gtk!1473

6 years agoDrop gdk_surface_is_visible
Matthias Clasen [Tue, 25 Feb 2020 00:03:49 +0000 (19:03 -0500)]
Drop gdk_surface_is_visible

It has been replaced by gdk_surface_get_mapped.

6 years agoReplace gdk_surface_is_visible by _get_mapped
Matthias Clasen [Tue, 25 Feb 2020 00:02:34 +0000 (19:02 -0500)]
Replace gdk_surface_is_visible by _get_mapped

The property  is called ::mapped, and we want to get
to standard getter naming.

6 years agoAdd gdk_surface_get_mapped
Matthias Clasen [Mon, 24 Feb 2020 22:59:12 +0000 (17:59 -0500)]
Add gdk_surface_get_mapped

Returns the value of the ::mapped property. This is
a direct replacement for gtk_surface_is_visible.

6 years agoMerge branch 'getters-and-setters' into 'master'
Matthias Clasen [Mon, 24 Feb 2020 20:31:22 +0000 (20:31 +0000)]
Merge branch 'getters-and-setters' into 'master'

gdk:Getters and setters

See merge request GNOME/gtk!1472

6 years agoAdd missing GdkDrag getters
Matthias Clasen [Mon, 24 Feb 2020 13:32:15 +0000 (08:32 -0500)]
Add missing GdkDrag getters

6 years agosurface: Add a getter for autohide
Matthias Clasen [Mon, 24 Feb 2020 13:01:19 +0000 (08:01 -0500)]
surface: Add a getter for autohide

6 years agogdk: Drop GdkDevice::input-mode and rename ::input-source
Matthias Clasen [Mon, 24 Feb 2020 18:35:27 +0000 (13:35 -0500)]
gdk: Drop GdkDevice::input-mode and rename ::input-source

Drop the input-mode, since it only makes sense for
floating devices, which we don't have anymore. And renamt
::input-source to ::source, to match the getter.

Update all users.

6 years agodevice: Add missing getters
Matthias Clasen [Mon, 24 Feb 2020 13:00:11 +0000 (08:00 -0500)]
device: Add missing getters

This adds getters for a few properties that were
missing them, and renames the input-mode and input-source
properties to match their existing getters.

6 years agoAdd a getter for GdkAppLaunchContext::display
Matthias Clasen [Mon, 24 Feb 2020 12:39:20 +0000 (07:39 -0500)]
Add a getter for GdkAppLaunchContext::display

6 years agoFix the build with docs
Matthias Clasen [Mon, 24 Feb 2020 13:22:22 +0000 (08:22 -0500)]
Fix the build with docs

This is fallout from filechooser api changes.

6 years agoMerge branch 'wip/ebassi/filechooser-new' into 'master'
Matthias Clasen [Mon, 24 Feb 2020 00:32:23 +0000 (00:32 +0000)]
Merge branch 'wip/ebassi/filechooser-new' into 'master'

Clean up the GtkFileChooser API

Closes #2455

See merge request GNOME/gtk!1454

6 years agoMerge branch '138-gtk4-install-valgrind-suppressions' into 'master'
Matthias Clasen [Mon, 24 Feb 2020 00:23:11 +0000 (00:23 +0000)]
Merge branch '138-gtk4-install-valgrind-suppressions' into 'master'

build: Install Valgrind suppressions files

Closes #138

See merge request GNOME/gtk!1467

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Mon, 24 Feb 2020 00:03:09 +0000 (00:03 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

broadway: Remove SURFACE_IS_TOPLEVEL

See merge request GNOME/gtk!1469

6 years agobroadway: Remove SURFACE_IS_TOPLEVEL
Matthias Clasen [Sun, 23 Feb 2020 23:15:59 +0000 (18:15 -0500)]
broadway: Remove SURFACE_IS_TOPLEVEL

All surfaces are toplevels now.

6 years agobuild: Install Valgrind suppressions files
Philip Chimento [Sun, 23 Feb 2020 23:00:37 +0000 (15:00 -0800)]
build: Install Valgrind suppressions files

This is so that other programs linking to GTK can use GTK's suppressions
files when performing their own Valgrind analysis.

Closes: #138
6 years agoUpdate POTFILES.in
Piotr Drąg [Sun, 23 Feb 2020 11:32:30 +0000 (12:32 +0100)]
Update POTFILES.in

6 years agoMerge branch 'wip/otte/dnd' into 'master'
Matthias Clasen [Sun, 23 Feb 2020 01:50:52 +0000 (01:50 +0000)]
Merge branch 'wip/otte/dnd' into 'master'

Get rid of GdkAtom

See merge request GNOME/gtk!1465

6 years agogdk: Remove GdkAtom
Benjamin Otte [Sun, 23 Feb 2020 00:54:38 +0000 (01:54 +0100)]
gdk: Remove GdkAtom

finally!!!!!

6 years agowin32: Get rid of GdkAtom
Benjamin Otte [Sun, 23 Feb 2020 00:43:42 +0000 (01:43 +0100)]
win32: Get rid of GdkAtom

6 years agowayland: Replace final mention of GdkAtom
Benjamin Otte [Sun, 23 Feb 2020 00:36:49 +0000 (01:36 +0100)]
wayland: Replace final mention of GdkAtom

6 years agox11: Get rid of GdkAtom and APIs supporting it.
Benjamin Otte [Sun, 23 Feb 2020 00:33:56 +0000 (01:33 +0100)]
x11: Get rid of GdkAtom and APIs supporting it.

replace all uses with const char * (non-interned).
Also remove a lot fo juggling from atom to GdkAtom to string and back.

The X Atom hash table is now mapping to (again, non-interned) strings.

6 years agodevice: gdk_device_list_axes() => gdk_device_get_axis_names()
Benjamin Otte [Sat, 22 Feb 2020 22:31:24 +0000 (23:31 +0100)]
device: gdk_device_list_axes() => gdk_device_get_axis_names()

Turn a GList of GdkAtom into a char ** - and rename the function to not
cause problems.

6 years agogdk: Remove gdk_text_property_to_utf8_list_for_display()
Benjamin Otte [Sat, 22 Feb 2020 22:15:25 +0000 (23:15 +0100)]
gdk: Remove gdk_text_property_to_utf8_list_for_display()

A lot of files became empty now, so they have been removed, which makes
this commit seem larger than it is.

6 years agoDon't use GdkAtom where const char * is used
Benjamin Otte [Sat, 22 Feb 2020 21:52:30 +0000 (22:52 +0100)]
Don't use GdkAtom where const char * is used

Those are all forgotten transitions while updating code to new APIs.

6 years agogdk: Remove gdk_utf8_to_string_target()
Benjamin Otte [Sat, 22 Feb 2020 17:33:20 +0000 (18:33 +0100)]
gdk: Remove gdk_utf8_to_string_target()

Only keep the X11 version around in the backend.

6 years agoselection: Remove GtkSelectionData
Benjamin Otte [Sat, 22 Feb 2020 17:18:00 +0000 (18:18 +0100)]
selection: Remove GtkSelectionData

6 years agodroptarget: Remove selectiondata read functions
Benjamin Otte [Sat, 22 Feb 2020 16:36:58 +0000 (17:36 +0100)]
droptarget: Remove selectiondata read functions

They are unused now.

6 years agofilechooserwidget: Stop using selection data
Benjamin Otte [Sat, 22 Feb 2020 16:16:56 +0000 (17:16 +0100)]
filechooserwidget: Stop using selection data

Use gdk_drop_read_async()

6 years agox11: Register DND atoms with all other atoms
Benjamin Otte [Sat, 22 Feb 2020 15:08:46 +0000 (16:08 +0100)]
x11: Register DND atoms with all other atoms

It's 2020, there's no need to be restrained with registering atoms.

6 years agogdk: Remove gdk_surface_register_dnd()
Benjamin Otte [Sat, 22 Feb 2020 14:56:36 +0000 (15:56 +0100)]
gdk: Remove gdk_surface_register_dnd()

All surfaces are expected to be DND surfaces from creation.

6 years agoMerge branch 'x11-dnd-fixes' into 'master'
Matthias Clasen [Sun, 23 Feb 2020 00:21:54 +0000 (00:21 +0000)]
Merge branch 'x11-dnd-fixes' into 'master'

X11 dnd fixes

See merge request GNOME/gtk!1464

6 years agoAdd detail to gdk_drag_begin docs
Matthias Clasen [Sat, 22 Feb 2020 23:50:28 +0000 (18:50 -0500)]
Add detail to gdk_drag_begin docs

Mention that GTK keeps a reference while the drag
operation is ongoing.

6 years agox11: Fix dnd coordinate handling
Matthias Clasen [Sat, 22 Feb 2020 23:44:55 +0000 (18:44 -0500)]
x11: Fix dnd coordinate handling

We were not properly converting the coordinates we
got to root coordinates. This was showing up as offsets
between the actual drop target and the area where drops
can happen, e.g. when dragging over a stack switcher
to switch pages.

6 years agox11: Export gdk_x11_surface_get_root_coords privately
Matthias Clasen [Sun, 23 Feb 2020 00:09:18 +0000 (19:09 -0500)]
x11: Export gdk_x11_surface_get_root_coords privately

This lets us avoid a roundtrip through the surface vfuncs.

6 years agox11: Keep a ref on GdkDrag objects
Matthias Clasen [Sat, 22 Feb 2020 23:32:37 +0000 (18:32 -0500)]
x11: Keep a ref on GdkDrag objects

It is expected that backends keep a ref on the GdkDrag
objects that they create as long as the drag is ongoing.

6 years agox11: Avoid crashes in dnd
Matthias Clasen [Sat, 22 Feb 2020 22:44:36 +0000 (17:44 -0500)]
x11: Avoid crashes in dnd

We were forgetting to clean up the ::xevent signal
handler in some error cases. Move the signal connection
later, when we know the drag is going forward, and
use g_signal_connect_object to make sure the signal
handler is not forgotten.

6 years agoMerge branch 'wip/wayland-fix-popup-grabs' into 'master'
Matthias Clasen [Sat, 22 Feb 2020 20:51:32 +0000 (20:51 +0000)]
Merge branch 'wip/wayland-fix-popup-grabs' into 'master'

Fix Wayland popup grabs

See merge request GNOME/gtk!1463

6 years agowayland/popup: Emit un-withdrawn event earlier
Jonas Ådahl [Sat, 22 Feb 2020 19:09:38 +0000 (20:09 +0100)]
wayland/popup: Emit un-withdrawn event earlier

Otherwise grabbing the seat will appear to have failed.

6 years agowayland/popup: Remove unnecessary checks when mapping popup
Jonas Ådahl [Sat, 22 Feb 2020 19:08:37 +0000 (20:08 +0100)]
wayland/popup: Remove unnecessary checks when mapping popup

We only call this when we're not already mapped so don't check that. We
also only call this when we should be mapped so don't check that either.

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Sat, 22 Feb 2020 19:01:18 +0000 (19:01 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

Fix a hard-to-spot typo

See merge request GNOME/gtk!1462

6 years agoFix a hard-to-spot typo
Matthias Clasen [Sat, 22 Feb 2020 18:49:12 +0000 (13:49 -0500)]
Fix a hard-to-spot typo

The symptom caused by this was scales in
popovers not reacting to dragging.

6 years agodocs: Add migration notes for GtkFileChooser
Emmanuele Bassi [Sat, 22 Feb 2020 18:07:11 +0000 (18:07 +0000)]
docs: Add migration notes for GtkFileChooser

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Sat, 22 Feb 2020 16:41:29 +0000 (16:41 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

x11: Fix a crash in event handling

See merge request GNOME/gtk!1461

6 years agox11: Fix a crash in event handling
Matthias Clasen [Sat, 22 Feb 2020 16:41:29 +0000 (16:41 +0000)]
x11: Fix a crash in event handling

This was overlooked in 79b4510c6d687c.

6 years agoRemove preview widget from GtkFileChooser
Emmanuele Bassi [Sat, 22 Feb 2020 16:39:01 +0000 (16:39 +0000)]
Remove preview widget from GtkFileChooser

The preview widget harks from a platform before time, when we didn't
have GIO, or a thumbnail specification.

Very few applications use it correctly, if at all; it has an horrid hack
to deal with the ownership of the widget's instance when accessed
through the getter function; it messes up the layout of the widget and
its label is less than useful when it comes to file names longer than a
dozen characters; it's a poor substitute for a proper thumbnail view.

6 years agoFix gdk docs build
Matthias Clasen [Sat, 22 Feb 2020 15:43:37 +0000 (10:43 -0500)]
Fix gdk docs build

6 years agoRemove GtkFileChooserEntry:local-only
Emmanuele Bassi [Sat, 22 Feb 2020 15:20:53 +0000 (15:20 +0000)]
Remove GtkFileChooserEntry:local-only

We don't use it any more in GtkFileChooserWidget.

6 years agoRemove GtkPlacesSidebar:local-only
Emmanuele Bassi [Sat, 22 Feb 2020 15:16:13 +0000 (15:16 +0000)]
Remove GtkPlacesSidebar:local-only

We don't use it any more in GtkFileChooserWidget.

6 years agoRemove GtkPlacesView:local-only
Emmanuele Bassi [Sat, 22 Feb 2020 15:03:31 +0000 (15:03 +0000)]
Remove GtkPlacesView:local-only

We don't use it any more from the file chooser widget.

6 years agoRemove GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER
Emmanuele Bassi [Sat, 22 Feb 2020 14:54:48 +0000 (14:54 +0000)]
Remove GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER

We don't need a whole separate action, now that the file chooser widget
can create folders; we can create use SELECT_FOLDER and create one.

6 years agoRemove GtkFileChooser:local-only
Emmanuele Bassi [Fri, 21 Feb 2020 16:44:39 +0000 (16:44 +0000)]
Remove GtkFileChooser:local-only

Now that the whole API goes through GFile we don't have the weird split
between local-only and non-local-only modes.

6 years agoRemove GtkFileChooser:show-hidden
Emmanuele Bassi [Fri, 21 Feb 2020 16:28:31 +0000 (16:28 +0000)]
Remove GtkFileChooser:show-hidden

This is a user setting and a user action, not something that ought to be
programmatically set via the file selection API.

6 years agoRemove overwrite confirmation machinery from GtkFileChooser
Emmanuele Bassi [Fri, 21 Feb 2020 15:52:47 +0000 (15:52 +0000)]
Remove overwrite confirmation machinery from GtkFileChooser

Overwrite confirmation should not be optional, and it should not loop
into application code to create their own dialog and user response.

6 years agoDrop GtkFileChooser:extra-widget
Emmanuele Bassi [Fri, 21 Feb 2020 15:34:37 +0000 (15:34 +0000)]
Drop GtkFileChooser:extra-widget

We have "choices" as a more rational (and portable) API; additionally,
the ownership semantics of the extra widget property getter are a hack.

6 years agoRemove filename/URI API from GtkFileChooser
Emmanuele Bassi [Fri, 21 Feb 2020 15:11:15 +0000 (15:11 +0000)]
Remove filename/URI API from GtkFileChooser

GtkFileChooser's API predates GIO by a few years, so it started off with
filenames and URI as character arrays. After introducing GIO as a
dependency, the API included GFile-based entry points.

It's much more appropriate to use GFile everywhere, as we want to
encourage people to use GIO instead of passing random bytes to low level
POSIX API.

See: #2455

6 years agoMerge branch 'wip/otte/dnd' into 'master'
Benjamin Otte [Sat, 22 Feb 2020 14:53:13 +0000 (14:53 +0000)]
Merge branch 'wip/otte/dnd' into 'master'

stuff

See merge request GNOME/gtk!1460

6 years agoRemove GdkSeatGrabPrepareFunc from headers
Matthias Clasen [Sat, 22 Feb 2020 03:18:05 +0000 (22:18 -0500)]
Remove GdkSeatGrabPrepareFunc from headers

It is not used in public api anymore.

6 years agoAdd a warning when a grab fails
Matthias Clasen [Sat, 22 Feb 2020 03:03:28 +0000 (22:03 -0500)]
Add a warning when a grab fails

This reveals that the grabs for popover menus
always fail now, causing the menus to not properly
hide.

6 years agotests: Guard variables with necessary macros
Benjamin Otte [Sat, 22 Feb 2020 06:44:16 +0000 (07:44 +0100)]
tests: Guard variables with necessary macros

6 years agotreeviewcolumn: Inline variable into return_if_fail()
Benjamin Otte [Sat, 22 Feb 2020 06:42:13 +0000 (07:42 +0100)]
treeviewcolumn: Inline variable into return_if_fail()

6 years agotestsuite: Don't use g_return_if_fail()
Benjamin Otte [Sat, 22 Feb 2020 06:41:14 +0000 (07:41 +0100)]
testsuite: Don't use g_return_if_fail()

Use g_assert()

6 years agotestsuite: Don't use return_if_fail()
Benjamin Otte [Sat, 22 Feb 2020 06:35:23 +0000 (07:35 +0100)]
testsuite: Don't use return_if_fail()

Use assert() instead